Repository navigation
Move nested modules handling into a separate function - #1306
Merged
Merged
Conversation
Thirumalai-Shaktivel
added
ready for review
certik
approved these changes
Nov 18, 2022
certik
left a comment
certik
left a comment
Contributor
There was a problem hiding this comment.
I think this looks good, thanks for fixing it!
Let's merge this after the sync.
To set the correct module name to be imported. Also, set the correct import path
certik
force-pushed
the
nested_modules_02
branch
from
November 18, 2022 23:23
72328d7 to
9088078
Compare
Contributor
|
I rebased on top of the sync, let's see if everything passes. If so, we can merge. |
Collaborator
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #992, #1305